Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding the namespaceSelector for the MutatingWebhookConfiguration in the helm chart. #2572

Closed
r0bobo opened this issue Mar 21, 2022 · 5 comments · Fixed by #2724
Closed

Allow overriding the namespaceSelector for the MutatingWebhookConfiguration in the helm chart. #2572

r0bobo opened this issue Mar 21, 2022 · 5 comments · Fixed by #2724
Assignees
@Volatus
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@r0bobo
Copy link

r0bobo commented Mar 21, 2022

I want the Mutating Admission Webhook to inject pod readiness gates in all namespace without having to label them.
I currently do this with some kustomize patching but it would be nice to be able to override the namespaceSelector directly from the helm chart.
@kishorj
Copy link
Collaborator

kishorj commented Mar 23, 2022

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 23, 2022
@kishorj kishorj added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Mar 23, 2022
@kishorj
Copy link
Collaborator

kishorj commented Mar 23, 2022

we can definitely move the namespace selector to the values and allow user to customize it.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 21, 2022
@r0bobo
Copy link
Author

r0bobo commented Jun 22, 2022

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 22, 2022
@Volatus
Copy link
Contributor

Volatus commented Jul 10, 2022

/assign

@Volatus Volatus mentioned this issue Jul 10, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Volatus Volatus

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Helm: Add field for Webhook namespace selector Volatus/aws-load-balancer-controller
5 participants
@kishorj @r0bobo @k8s-ci-robot @Volatus @k8s-triage-robot