New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm: Add field for Webhook namespace selector #2724
Helm: Add field for Webhook namespace selector #2724
Conversation
Signed-off-by: Ismayil Mirzali <ismayilmirzeli@gmail.com>
Hi @Volatus. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind feature |
@Volatus: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## main #2724 +/- ##
=======================================
Coverage 53.99% 53.99%
=======================================
Files 144 144
Lines 8214 8214
=======================================
Hits 4435 4435
Misses 3461 3461
Partials 318 318 Continue to review full report at Codecov.
|
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, Volatus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest |
Signed-off-by: Ismayil Mirzali <ismayilmirzeli@gmail.com>
Issue
Fixes #2572
Description
Adds the config option
webhookNamespaceSelectors
so that the user is able to specify a different one than the default.Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く