Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Add field for Webhook namespace selector #2724

Merged

Conversation

Volatus
Copy link
Contributor

@Volatus Volatus commented Jul 10, 2022

Issue

Fixes #2572

Description

Adds the config option webhookNamespaceSelectors so that the user is able to specify a different one than the default.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

Signed-off-by: Ismayil Mirzali <ismayilmirzeli@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 10, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @Volatus. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 10, 2022
@Volatus
Copy link
Contributor Author

Volatus commented Jul 10, 2022

/kind feature
/ok-to-test
/cc @kishorj

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 10, 2022
@k8s-ci-robot
Copy link
Contributor

@Volatus: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/kind feature
/ok-to-test
/cc @kishorj

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

Codecov Report

Merging #2724 (58d6de9) into main (d8ee617) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2724   +/-   ##
=======================================
  Coverage   53.99%   53.99%           
=======================================
  Files         144      144           
  Lines        8214     8214           
=======================================
  Hits         4435     4435           
  Misses       3461     3461           
  Partials      318      318           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update d8ee617...58d6de9. Read the comment docs.

@kishorj
Copy link
Collaborator

kishorj commented Jul 15, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 15, 2022
@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, Volatus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2022
@kishorj
Copy link
Collaborator

kishorj commented Jul 29, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2022
@Volatus
Copy link
Contributor Author

Volatus commented Jul 29, 2022

/retest

@k8s-ci-robot k8s-ci-robot merged commit 80888b9 into kubernetes-sigs:main Jul 29, 2022
@Volatus Volatus deleted the helm-add-namespace-selector branch July 29, 2022 18:19
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
Signed-off-by: Ismayil Mirzali <ismayilmirzeli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow overriding the namespaceSelector for the MutatingWebhookConfiguration in the helm chart.
4 participants