-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to get EC2 instance ID differently #3487
Comments
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Is your feature request related to a problem?
This is best described in this issue (which I already closed): #3485 - but in summary:
Describe the solution you'd like
If the instance ID is not configured into the Node.Spec.ProviderID, it may be possible to determine the instance ID in a number of different ways. One way would be:
Another way would be to use a defined node label, e.g.:
Then perform the same logic described above except select the EC2 instance with an internal IP address matching the value of the node label.
Describe alternatives you've considered
I could add a step to our RKE2 provisioner that patches
Node.Spec.ProviderID
with the EC2 instance ID.Summary
I would be happy to submit a PR but before beginning work on this I would like to reach alignment on the exact approach. At this time I think the following might be simplest and clearest for the person configuring the controller:
The text was updated successfully, but these errors were encountered: