-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce one target group per target group binding #2098
Conversation
Hi @fawadkhaliq. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @M00nF1sh |
Codecov Report
@@ Coverage Diff @@
## main #2098 +/- ##
=======================================
Coverage 49.23% 49.23%
=======================================
Files 130 130
Lines 7036 7046 +10
=======================================
+ Hits 3464 3469 +5
- Misses 3294 3297 +3
- Partials 278 280 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
🥂
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fawadkhaliq, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue
#2092
Description
Prevent creation of TargetGroupBinding if its already referenced by an existing TargetGroup
TargetGroupBinding has a one-to-one mapping with TargetGroup as per the data model, however, the controller does not enforce this behavior. This can lead to two TargetGroupBinding resources point to the same TargetGroup.
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯