Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change of text "your-cluster-name" #3152

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Change of text "your-cluster-name" #3152

merged 2 commits into from
Aug 23, 2023

Conversation

git4example
Copy link
Contributor

Issue

Description

Currently installation instructions indicate to replace <INSERT_CLUSTER_NAME> however manifest files are having your-cluster-name makes difficult to find location where to replace text.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 14, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Welcome @git4example!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 14, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @git4example. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 14, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 13, 2023
@git4example
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 17, 2023
johngmyers
johngmyers suggested changes Jul 18, 2023
View reviewed changes
docs/deploy/installation.md Outdated Show resolved Hide resolved
@git4example @johngmyers
Update docs/deploy/installation.md
f06e1e8 
Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>
@johngmyers
Copy link
Contributor

/ok-to-test
/lgtm
/assign @M00nF1sh

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 29, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2023
@oliviassss oliviassss added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Aug 22, 2023
M00nF1sh
M00nF1sh approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: git4example, M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit dbf98e0 into kubernetes-sigs:main Aug 23, 2023
4 of 5 checks passed
shraddhabang pushed a commit to shraddhabang/aws-load-balancer-controller that referenced this pull request Oct 17, 2023
@git4example @johngmyers @shraddhabang
Change of text "your-cluster-name" (kubernetes-sigs#3152)
8d09b38 
* Change of text "your-cluster-name"

* Update docs/deploy/installation.md

Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>

---------

Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>
johngmyers pushed a commit to johngmyers/aws-load-balancer-controller that referenced this pull request Feb 6, 2024
Pull request kubernetes-sigs#7: IENGOC-39: Remediate http/2 vulnerabi…
a622844 
…lity

Merge in DEL/aws-load-balancer-controller-fork from IENGOC-39 to main

* commit '3e26f86e82a5d419a7f8adfc5c95dd45984be6f4':
  IENGOC-39: Remediate more bd vulnerabilities
  IENGOC-39: Remediate bd vulnerabilities
  cut v2.6.2 release (kubernetes-sigs#3453)
  update ci e2e script for cert IDs (kubernetes-sigs#3392)
  fix test failure
  doc updates (kubernetes-sigs#3426)
  Change of text "your-cluster-name" (kubernetes-sigs#3152)
  slice init style suggestion
  whitespace
  group errors, emit one event per reconcile, requeue on failure
  don't block TGB reconciliation loop on failed SG ingress reconciliation
  fix: remove service from function args
  feat: resolve health check port name for NLB
  Expose ingress configuration options for missing backends (kubernetes-sigs#3342)
  Stricter dependency/security review
  remove unnecessary patch requests (kubernetes-sigs#3380)
  increase timeout to 2h in ci scripts
  wait for the TG to be healthy before cleanup any resource
jkdihenkar pushed a commit to jkdihenkar/aws-load-balancer-controller that referenced this pull request Mar 1, 2024
@git4example @johngmyers @jkdihenkar
Change of text "your-cluster-name" (kubernetes-sigs#3152)
6929a37 
* Change of text "your-cluster-name"

* Update docs/deploy/installation.md

Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>

---------

Co-authored-by: John Gardiner Myers <jgmyers@proofpoint.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers requested changes

@M00nF1sh M00nF1sh M00nF1sh approved these changes

Assignees

@johngmyers johngmyers

@M00nF1sh M00nF1sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@git4example @k8s-ci-robot @k8s-triage-robot @johngmyers @M00nF1sh @oliviassss