Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check both sdkLS and resLS sslpolicy for nil #3196

Merged
merged 1 commit into from
May 15, 2023

Conversation

oliviassss
Copy link
Collaborator

Issue

#3185

Description

Check both sdkLS and resLS sslpolicy for nil when updating extra certificates for listeners. This PR fixes the edge case that when adding ssl certs to an existing service that has no ssl cert originally, the controller will not skip adding extra certs because of the sslpolicy is nil in sdkLS.

Tests

  • Created a NLB with no ssl cert specified, then added multiple certs via annotation service.beta.kubernetes.io/aws-load-balancer-ssl-cert, verified all the certs got added to the listeners of the NLB successfully
  • Created a ALB with no ssl cert specified, then added multiple certs via annotation alb.ingress.kubernetes.io/certificate-arn, verified all the certs got added to the listeners of the ALB successfully

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 11, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (ff8c13d) 55.05% compared to head (841f97b) 55.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3196   +/-   ##
=======================================
  Coverage   55.05%   55.05%           
=======================================
  Files         148      148           
  Lines        8532     8532           
=======================================
  Hits         4697     4697           
  Misses       3505     3505           
  Partials      330      330           
Impacted Files Coverage Δ
pkg/deploy/elbv2/listener_manager.go 1.08% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 12, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, oliviassss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2023
@kishorj
Copy link
Collaborator

kishorj commented May 15, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1645277 into kubernetes-sigs:main May 15, 2023
@oliviassss oliviassss deleted the fix-ls-cert branch May 15, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants