check both sdkLS and resLS sslpolicy for nil #3196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#3185
Description
Check both sdkLS and resLS sslpolicy for nil when updating extra certificates for listeners. This PR fixes the edge case that when adding ssl certs to an existing service that has no ssl cert originally, the controller will not skip adding extra certs because of the sslpolicy is nil in sdkLS.
Tests
service.beta.kubernetes.io/aws-load-balancer-ssl-cert
, verified all the certs got added to the listeners of the NLB successfullyalb.ingress.kubernetes.io/certificate-arn
, verified all the certs got added to the listeners of the ALB successfullyChecklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯