Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/framework: replace deprecated ioutil.ReadAll #3256

Merged

Conversation

komisan19
Copy link
Contributor

@komisan19 komisan19 commented Jun 24, 2023

Issue

Description

This package is deprecated.
so, change to io/ioutil -> io

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 24, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @komisan19. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 24, 2023
@johngmyers
Copy link
Contributor

/ok-to-test
/lgtm
/assign @kishorj

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 25, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2023
@kishorj kishorj added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 21, 2023
@kishorj
Copy link
Collaborator

kishorj commented Jul 21, 2023

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishorj, komisan19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (940efc7) 54.70% compared to head (f71604c) 54.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3256   +/-   ##
=======================================
  Coverage   54.70%   54.70%           
=======================================
  Files         148      148           
  Lines        8590     8590           
=======================================
  Hits         4699     4699           
  Misses       3559     3559           
  Partials      332      332           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kishorj
Copy link
Collaborator

kishorj commented Jul 28, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit 513c8fc into kubernetes-sigs:main Jul 28, 2023
7 checks passed
johngmyers added a commit to johngmyers/aws-load-balancer-controller that referenced this pull request Feb 6, 2024
…to 2.6.0

Merge in DEL/aws-load-balancer-controller-fork from merge-up to main

* commit '195e896b0efbd467694bb9a19de7c5a12c5dde8c': (71 commits)
  check the canary test result and exit if it failed
  Apply suggestions from code review
  Update docs/guide/service/annotations.md
  Addressing the comment
  Remove dependency on aws-sdk-go-v2 (kubernetes-sigs#3320)
  Update live docs for NLB-SG feature release
  cut v2.6.0 release
  refactor targetGroupBinding network builder
  Add support for NLB security groups
  Allow TLS 1.2 with restricted ciphers for webhooks
  Update the RSA filter for Cert discovery
  Doc: Add note for rename behavior of IngressGroup (kubernetes-sigs#3283)
  Make Ingress validating webhook ignore ingresses not managed by AWS LBC (kubernetes-sigs#3272)
  add oliviassss as reviewer
  fix the race condition in pod cache and endpoint resolver
  Bump github.com/onsi/ginkgo/v2 from 2.6.0 to 2.11.0
  Bump github.com/aws/aws-sdk-go from 1.44.184 to 1.44.294 (kubernetes-sigs#3271)
  Provide better explanation of failure to find a subnet (kubernetes-sigs#3292)
  test/framework: replace deprecated ioutil.ReadAll (kubernetes-sigs#3256)
  Add warning in doc for ServiceMutatorWebhook (kubernetes-sigs#3180)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants