Introduce multi-rule and target group support #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Listener recreates when modification occurs.
- Currently supports multiple listeners with the following not implemented: -- Listeners can only bind to 1 ARN cert -- Listeners only point to one target group TODO: Must revise tests based on change.
Prevents crash when subnets are not valid. Solves #32.
Fixing up the GitLab CI jobs See merge request !16
Added: + Rule for each path can route to a unique target group. + Reassemples rules and their correlations to TGs when alb ingress starts. + Multiple listeners supported + Multiple updates to make Listener changes more stable + Ensures current state of Listeners and Rules are stripped with LB modification required the lb is deleted. + Corrected large listener memory link (growing list over time). Todo: + Need to further refine path updates in ingress resources + Few TODOs mention in code
Additional IAM policy permissions See merge request !17
# Conflicts: # pkg/cmd/controller/elbv2_listener_test.go
This was referenced Apr 6, 2017
bigkraig
pushed a commit
that referenced
this pull request
Oct 1, 2018
Introduce multi-rule and target group support
thejasn
pushed a commit
to thejasn/aws-load-balancer-controller
that referenced
this pull request
Apr 7, 2022
Rebase to v2.4.1 from upstream
alebedev87
pushed a commit
to alebedev87/aws-load-balancer-controller
that referenced
this pull request
Oct 26, 2023
Rebase to v2.4.1 from upstream
johngmyers
added a commit
to johngmyers/aws-load-balancer-controller
that referenced
this pull request
Feb 6, 2024
…to 2.6.0 Merge in DEL/aws-load-balancer-controller-fork from merge-up to main * commit '195e896b0efbd467694bb9a19de7c5a12c5dde8c': (71 commits) check the canary test result and exit if it failed Apply suggestions from code review Update docs/guide/service/annotations.md Addressing the comment Remove dependency on aws-sdk-go-v2 (kubernetes-sigs#3320) Update live docs for NLB-SG feature release cut v2.6.0 release refactor targetGroupBinding network builder Add support for NLB security groups Allow TLS 1.2 with restricted ciphers for webhooks Update the RSA filter for Cert discovery Doc: Add note for rename behavior of IngressGroup (kubernetes-sigs#3283) Make Ingress validating webhook ignore ingresses not managed by AWS LBC (kubernetes-sigs#3272) add oliviassss as reviewer fix the race condition in pod cache and endpoint resolver Bump github.com/onsi/ginkgo/v2 from 2.6.0 to 2.11.0 Bump github.com/aws/aws-sdk-go from 1.44.184 to 1.44.294 (kubernetes-sigs#3271) Provide better explanation of failure to find a subnet (kubernetes-sigs#3292) test/framework: replace deprecated ioutil.ReadAll (kubernetes-sigs#3256) Add warning in doc for ServiceMutatorWebhook (kubernetes-sigs#3180) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will be re-based against the work done in #1, once it's merged.
Added:
starts.
modification required the lb is deleted.
Todo: