Support KOPS values for private/public subnet tags #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
Thanks! I didn't see that we could use wildcards. |
|
@bigkraig |
|
@m15o Do you have any logs to share? |
|
@argeualcantara I deleted a EKS cluster and created new one with the same cluster name. I forgot to delete target groups created by the old cluster. Then the new cluster tries to create the target group with the same name and failed. |
bigkraig
added a commit
that referenced
this pull request
Oct 1, 2018
Support KOPS values for private/public subnet tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kops uses "1", and "true" for older versions, having to change and monitor every subnet to check if the value is empty is not practical at all, with this we check if the tag is the expected for private or public subnets, not it's value. Please consider this change.