Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leader-election-type has been removed in csi attacher v2.x #339

Closed
Colstuwjx opened this issue Mar 30, 2020 · 2 comments · Fixed by #377
Closed

leader-election-type has been removed in csi attacher v2.x #339

Colstuwjx opened this issue Mar 30, 2020 · 2 comments · Fixed by #377

Comments

@Colstuwjx
Copy link

Is your feature request related to a problem?/Why is this needed
I found that our attacher deploy yaml still includes -leader-election-type, it may works right now, since we're using v1.2.0, but It has been removed since v2.0, see ref.

Describe the solution you'd like in detail
While we're prepared to upgrade the attacher version to v2.0, don't forget to remove this line. Otherwise, the csi attacher container would panic.

Describe alternatives you've considered
None.

Additional context
None.

@andyzhangx
Copy link
Member

thanks for reminder, you are working on kubernetes-csi-tencentcloud, right?

@Colstuwjx
Copy link
Author

Yes, I'm not from tencentcloud, my corp is using tencentcloud infra, so I forked the repo.

sozercan pushed a commit to sozercan/azuredisk-csi-driver that referenced this issue Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants