Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade azure lib to fix panic issue on node driver #1081

Merged
merged 1 commit into from Nov 12, 2021

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: upgrade azure lib to fix panic issue on node driver

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Streaming logs below:
I1108 23:59:39.482207 3216 azuredisk.go:139] driver userAgent: disk.csi.azure.com/v1.8.0 gc/go1.17 (amd64-windows) aks-engine
I1108 23:59:39.511118 3216 azure_disk_utils.go:137] reading cloud config from secret kube-system/azure-cloud-provider
W1108 23:59:39.714249 3216 azure_disk_utils.go:144] InitializeCloudFromSecret: failed to get cloud config from secret kube-system/azure-cloud-provider: failed to get secret kube-system/azure-cloud-provider: secrets "azure-cloud-provider" not found
I1108 23:59:39.714249 3216 azure_disk_utils.go:149] could not read cloud config from secret kube-system/azure-cloud-provider
I1108 23:59:39.714249 3216 azure_disk_utils.go:152] AZURE_CREDENTIAL_FILE env var set as C:\k\azure.json
I1108 23:59:39.714249 3216 azure_disk_utils.go:167] read cloud config from file: C:\k\azure.json successfully
I1108 23:59:39.714249 3216 azure_auth.go:234] Using AzureStackCloud environment
W1108 23:59:39.714249 3216 azure_disk_utils.go:186] InitializeCloudFromConfig failed with error: open : The system cannot find the file specified.

I1108 23:59:41.203232 3216 utils.go:95] GRPC call: /csi.v1.Node/NodeGetInfo
I1108 23:59:41.203232 3216 utils.go:96] GRPC request: {}
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x68 pc=0x14f345b]

goroutine 53 [running]:
sigs.k8s.io/cloud-provider-azure/pkg/provider.(*Cloud).InstanceType(0xc0002fc000, {0xc0002753e0, 0xc000499d20}, {0xc00009e099, 0xa})
/mnt/vss/_work/1/go/src/sigs.k8s.io/azuredisk-csi-driver/vendor/sigs.k8s.io/cloud-provider-azure/pkg/provider/azure_instances.go:453 +0xfb
sigs.k8s.io/azuredisk-csi-driver/pkg/azuredisk.(*Driver).NodeGetInfo(0xc0004e03c0, {0x1c943d8, 0xc00047cbd0}, 0x2110b37)
/mnt/vss/_work/1/go/src/sigs.k8s.io/azuredisk-csi-driver/pkg/azuredisk/nodeserver.go:324 +0x3de

Release note:

fix: upgrade azure lib to fix panic issue on node driver

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2021
@edreed
Copy link
Collaborator

edreed commented Nov 12, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2bf6c29 into kubernetes-sigs:master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants