Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support volume cloning #196

Merged
merged 6 commits into from
Nov 28, 2019
Merged

feat: support volume cloning #196

merged 6 commits into from
Nov 28, 2019

Conversation

ZeroMagic
Copy link
Member

@ZeroMagic ZeroMagic commented Nov 25, 2019 •
edited

What type of PR is this?
/kind feature

What this PR does / why we need it:
Support volume cloning feature.
Now we can create a managed disk from an existing managed disk.

  • add volume cloning functionality
  • check whether there are sanity tests to cover this volume cloning functionality
  • add e2e tests for this volume cloning functionality
  • add a doc about volume cloning
  • update helm charts

Which issue(s) this PR fixes:

Fixes #153 #197

Special notes for your reviewer:
The related sanity tests have passed.

Release note:

support volume cloning

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 25, 2019
andyzhangx
andyzhangx reviewed Nov 25, 2019
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionality part LGTM

  • add a doc about volume cloning
  • check whether there are sanity tests to cover this volume cloning functionality
  • add e2e tests for this volume cloning functionality

pkg/azuredisk/azuredisk.go Show resolved Hide resolved
@ZeroMagic ZeroMagic changed the title feat: support volume cloning [WIP]feat: support volume cloning Nov 26, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 26, 2019
@ZeroMagic
Copy link
Member Author

There are two sanity tests to cover it.

------------------------------
Controller Service [Controller Server] CreateVolume
  should create volume from an existing source volume
  /root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/controller.go:782
STEP: reusing connection to CSI driver at unix:///tmp/csi.sock
STEP: creating mount and staging directories
STEP: creating a volume
STEP: creating a volume from source volume
STEP: cleaning up deleting the volume created from source volume
STEP: cleaning up deleting the source volume

• [SLOW TEST:16.370 seconds]
Controller Service [Controller Server]
/root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/tests.go:44
  CreateVolume
  /root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/controller.go:380
    should create volume from an existing source volume
    /root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/controller.go:782
------------------------------
Controller Service [Controller Server] CreateVolume
  should fail when the volume source volume is not found
  /root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/controller.go:817
STEP: reusing connection to CSI driver at unix:///tmp/csi.sock
STEP: creating mount and staging directories
STEP: creating a volume from source snapshot

• [SLOW TEST:5.945 seconds]
Controller Service [Controller Server]
/root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/tests.go:44
  CreateVolume
  /root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/controller.go:380
    should fail when the volume source volume is not found
    /root/go/src/github.com/kubernetes-csi/csi-test/pkg/sanity/controller.go:817
------------------------------

@ZeroMagic
feat: support volume cloning
a28d6fa 
Signed-off-by: ZeroMagic <anthonyliu@zju.edu.cn>
@ZeroMagic
docs: add volume cloning feature doc
f0bceb8 
Signed-off-by: ZeroMagic <anthonyliu@zju.edu.cn>
@ZeroMagic
Copy link
Member Author

Since the usage of helm 3 is very different from helm 2, I update the README.md.

In addition, if we want to use volume cloning, the version of external-provisioner is at least v1.4.0. After updating the templates, we can specify the images' tag in values.yaml without having to modify the templates every time

@ZeroMagic
Copy link
Member Author

/test pull-azuredisk-csi-driver-e2e-single-az

1 similar comment
@ZeroMagic
Copy link
Member Author

/test pull-azuredisk-csi-driver-e2e-single-az

@ZeroMagic
chore: update helm version and charts
cc45eef 
Signed-off-by: ZeroMagic <anthonyliu@zju.edu.cn>
@ZeroMagic
test: add the e2e test about volume cloing
6b1d2e0 
Signed-off-by: ZeroMagic <anthonyliu@zju.edu.cn>
@ZeroMagic
fix: set timeout of external-provisioner to 120s
07fbdcb 
Signed-off-by: ZeroMagic <anthonyliu@zju.edu.cn>
@ZeroMagic
chore: print azuredisk log in CI
c23d17e 
Signed-off-by: ZeroMagic <anthonyliu@zju.edu.cn>
@ZeroMagic ZeroMagic changed the title [WIP]feat: support volume cloning feat: support volume cloning Nov 27, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 27, 2019
@ZeroMagic
Copy link
Member Author

All tests have passed. We can continue to review.

andyzhangx
andyzhangx approved these changes Nov 28, 2019
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, ZeroMagic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit ad935c6 into kubernetes-sigs:master Nov 28, 2019
@andyzhangx andyzhangx mentioned this pull request Dec 1, 2019
Closed
sozercan pushed a commit to sozercan/azuredisk-csi-driver that referenced this pull request Aug 16, 2021
@andyzhangx
Merge pull request kubernetes-sigs#196 from kubernetes-sigs/create-fi…
d35cac1 
…leshare

fix: add retry in create file share
sunpa93 pushed a commit to sunpa93/azuredisk-csi-driver that referenced this pull request Oct 22, 2021
@edreed
chore: Add V2 driver CRIs to the e2e test logs after the run is compl…
4f74229 
…ete. (kubernetes-sigs#196)

* Add V2 driver CRIs to the e2e test logs after the run is complete.

* Fix resource name

* Add additional fields to kubectl AzVolume output
k8s-ci-robot pushed a commit that referenced this pull request Nov 2, 2021
@edreed @mukhoakash
chore: Add V2 driver CRIs to the e2e test logs after the run is compl…
795b155 
…ete. (#196)

* Add V2 driver CRIs to the e2e test logs after the run is complete.

* Fix resource name

* Add additional fields to kubectl AzVolume output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add docs for Volume Cloning feature
3 participants
@ZeroMagic @k8s-ci-robot @andyzhangx