Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: set provisioner timeout as 15s #523

Merged
merged 1 commit into from Sep 7, 2020
Merged

chore: set provisioner timeout as 15s #523

merged 1 commit into from Sep 7, 2020

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
chore: set provisioner timeout as 15s, 15s is the default value of csi-provisioner.

So 15s is quite a safe timeout value now.

Which issue(s) this PR fixes:

Fixes #366

Requirements:

Special notes for your reviewer:

Release note:

chore: set provisioner timeout as 15s

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 6, 2020
@andyzhangx andyzhangx mentioned this pull request Sep 6, 2020
Closed
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx merged commit 58b703a into kubernetes-sigs:master Sep 7, 2020
sozercan pushed a commit to sozercan/azuredisk-csi-driver that referenced this pull request Aug 16, 2021
@andyzhangx
Merge pull request kubernetes-sigs#523 from kubernetes-sigs/100tb
01f108b 
fix: ExceedsAccountLimit issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provisioning fails with default values for --timeout and --connection-timeout
2 participants
@andyzhangx @k8s-ci-robot