-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(dep): adds dep check in travis #65
Conversation
b4a0dc2
to
9d824a3
Compare
would you also fix this failure in this PR:
|
b2b4f1a
to
124acc8
Compare
Signed-off-by: Ashish Ranjan <ashishranjan738@gmail.com> This commit adds `dep check` in travis which will allow catching broken dependencies PR.
@andyzhangx fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, ashishranjan738 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
thanks, could you also fix it in azure file driver: kubernetes-sigs/azurefile-csi-driver#39, thanks. |
remove invalid OWNERS_ALIASES file
…ncy-openshift-4.16-ose-azure-disk-csi-driver OCPBUGS-24938: Updating ose-azure-disk-csi-driver-container image to be consistent with ART
Signed-off-by: Ashish Ranjan ashishranjan738@gmail.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
This commit adds
dep check
in travis which will allow catching broken dependencies PR.Which issue(s) this PR fixes:
Fixes #54
Special notes for your reviewer:
Merge this PR after #64 as curretly the vendor packages are not in sync and the PR #64 contains the changes of
dep ensure
.Release note: