Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(dep): adds dep check in travis #65

Merged
merged 1 commit into from
Mar 17, 2019

Conversation

ashishranjan738
Copy link
Contributor

@ashishranjan738 ashishranjan738 commented Mar 17, 2019

Signed-off-by: Ashish Ranjan ashishranjan738@gmail.com

What type of PR is this?
/kind feature

What this PR does / why we need it:
This commit adds dep check in travis which will allow catching broken dependencies PR.

Which issue(s) this PR fixes:

Fixes #54

Special notes for your reviewer:
Merge this PR after #64 as curretly the vendor packages are not in sync and the PR #64 contains the changes of dep ensure.

Release note:

adds dep check in travis

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 17, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 17, 2019
@andyzhangx
Copy link
Member

would you also fix this failure in this PR:

Verifying dep check
# Gopkg.lock is out of sync:
github.com/Azure/go-autorest/autorest/to: imported or required, but missing from Gopkg.lock's input-imports
# vendor is out of sync:
google.golang.org/api: hash of vendored tree not equal to digest in Gopkg.lock
k8s.io/kubernetes: hash of vendored tree not equal to digest in Gopkg.lock
The command "hack/verify-all.sh" exited with 1.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 17, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 17, 2019
@k8s-ci-robot k8s-ci-robot added sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 17, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 17, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 17, 2019
Signed-off-by: Ashish Ranjan <ashishranjan738@gmail.com>

This commit adds `dep check` in travis which will allow catching broken dependencies PR.
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 17, 2019
@ashishranjan738
Copy link
Contributor Author

would you also fix this failure in this PR:

Verifying dep check
# Gopkg.lock is out of sync:
github.com/Azure/go-autorest/autorest/to: imported or required, but missing from Gopkg.lock's input-imports
# vendor is out of sync:
google.golang.org/api: hash of vendored tree not equal to digest in Gopkg.lock
k8s.io/kubernetes: hash of vendored tree not equal to digest in Gopkg.lock
The command "hack/verify-all.sh" exited with 1.

@andyzhangx fixed

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, ashishranjan738

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2019
@andyzhangx
Copy link
Member

thanks, could you also fix it in azure file driver: kubernetes-sigs/azurefile-csi-driver#39, thanks.

@k8s-ci-robot k8s-ci-robot merged commit df1859b into kubernetes-sigs:master Mar 17, 2019
sozercan pushed a commit to sozercan/azuredisk-csi-driver that referenced this pull request Aug 16, 2021
jsafrane pushed a commit to jsafrane/azuredisk-csi-driver that referenced this pull request Dec 11, 2023
…ncy-openshift-4.16-ose-azure-disk-csi-driver

OCPBUGS-24938: Updating ose-azure-disk-csi-driver-container image to be consistent with ART
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add "dep ensure" check in CI test
3 participants