Refactor: Extract kubeclient from cloud provider #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
size/L
MartinForReal
force-pushed
the
shafan/token
branch
3 times, most recently
from
5ba5f74
to
7b30c24
Compare
|
/retest |
MartinForReal
force-pushed
the
shafan/token
branch
from
7b30c24
to
015f8e2
Compare
|
the ut coverage is dropped dramatically: |
MartinForReal
force-pushed
the
shafan/token
branch
2 times, most recently
from
f6ff58b
to
4e1317f
Compare
Signed-off-by: Fan Shang Xiang <shafan@microsoft.com>
MartinForReal
force-pushed
the
shafan/token
branch
from
4e1317f
to
486e50b
Compare
|
|
andyzhangx
reviewed
Dec 12, 2023
|
pull-blob-csi-driver-external-e2e-nfs
--
|
|
/test pull-blob-csi-driver-external-e2e-nfs |
|
I think it is a common practice to define flag only when it is used. It is easier to figure out unused flags. |
andyzhangx
reviewed
Dec 13, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, MartinForReal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Refactor: Extract kubeclient from cloud provider
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: