-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support install blobfuse proxy on other linux distributions #1173
Conversation
The installation scripts of mariner and ubuntu and any other Linux distributions basically have the same logical, so I use |
/retest |
@cvvz thanks for the quick fix! we did not realize that this csi driver is also used on other distros, in the future, I think we need to add some e2e tests or basic functional tests on other distros. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, cvvz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-1.23 |
/cherrypick release-1.22 |
/cherrypick release-1.21 |
@andyzhangx: #1173 failed to apply on top of branch "release-1.22":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@andyzhangx: new pull request created: #1174 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@andyzhangx: #1173 failed to apply on top of branch "release-1.21":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
fix: support install blobfuse proxy on other linux distributions
Which issue(s) this PR fixes:
Fixes #1172
Requirements:
Special notes for your reviewer:
The installation scripts of mariner and ubuntu and any other Linux distributions basically have the same logical, so I use
install-proxy.sh
as the entry point for all the Linux distributions except for coreos.Release note: