Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Managed Identity and Service Principal Name auth #146

Merged
merged 1 commit into from
May 20, 2020

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented May 3, 2020

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: support Managed Identity and Service Principal Name auth

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

  • set msiEndPoint in blobfuse storage class
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  name: blob
provisioner: blob.csi.azure.com
parameters:
  skuName: Standard_LRS
  azureStorageIdentityClientID: ""
  azureStorageIdentityObjectID: ""
  azureStorageIdentityResourceID: ""
  msiEndPoint: ""
reclaimPolicy: Retain
volumeBindingMode: Immediate
  • set msiSecret by k8s secret
kubectl create secret generic azure-secret --from-literal azurestorageaccountname=NAME --from-literal msisecret="secret" --type=Opaque

refer to https://github.com/Azure/azure-storage-fuse#environment-variables

Release note:

feat: support Managed Identity and Service Principal Name auth

/hold

@andyzhangx andyzhangx requested a review from ZeroMagic May 3, 2020 13:18
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 3, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from feiskyer May 3, 2020 13:18
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants