Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable mount options #68

Merged
merged 1 commit into from
Sep 6, 2019

Conversation

ZeroMagic
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
Each parameter in cmd should be separated with a blank. Otherwise, it won't work.

Which issue(s) this PR fixes:

Fixes #25

Special notes for your reviewer:

Release note:

fix: enable mount options

Signed-off-by: ZeroMagic <anthonyliu@zju.edu.cn>
- hostPath:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this required?

@andyzhangx andyzhangx merged commit 8376a77 into kubernetes-sigs:master Sep 6, 2019
@marcoboffi
Copy link

marcoboffi commented Apr 20, 2020

Sorry but I don't understand very well how it's possible define mountOption.
I found in your code that tmp_path is set by default to /mnt. But how can I set other parameters (in particular file-cache-timeout-in-seconds)? With values file during driver installation with helm?

@andyzhangx
Copy link
Member

Sorry but I don't understand very well how it's possible define mountOption.
I found in your code that tmp_path is set by default to /mnt. But how can I set other parameters (in particular file-cache-timeout-in-seconds)? With values file during driver installation with helm?

check example here: https://github.com/kubernetes-sigs/blobfuse-csi-driver/blob/master/deploy/example/storageclass-blobfuse-csi-mountoptions.yaml

@marcoboffi
Copy link

Great! But "-o uid=1000" or "allow_other" option are mandatory to use /mnt (Azure VM ephimeral disk) ?

@andyzhangx
Copy link
Member

Great! But "-o uid=1000" or "allow_other" option are mandatory to use /mnt (Azure VM ephimeral disk) ?

@marcoboffi they are not relevant. do you have any other requirement on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add mountOptions support
3 participants