New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use different base image to include go #136
Conversation
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com> Co-authored-by: Jason Hall <jason@chainguard.dev>
Hi @developer-guy. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for the PR @developer-guy ! /ok-to-test |
Thanks @developer-guy @imjasonh ! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: developer-guy, puerco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
That'd be great, and I'm also willing to help with this because I've played a bit with apko and melange to build a crane project with them recently. |
may I open an issue for this @puerco? |
@developer-guy -- Please do! |
Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com
Co-authored-by: Jason Hall jason@chainguard.dev
What type of PR is this?
/kind feature
/kind bug
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #135
Special notes for your reviewer:
After a quick chat with @imjasonh, thanks to him, we have agreed that the best way of providing a go binary for an image that is building with ko is changing the image's base with the one of the go binary installed. Fortunately, we have one, https://github.com/distroless/go. distroless.dev/go is an apko-built distroless image that includes go.
cc: @imjasonh
Does this PR introduce a user-facing change?