Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use different base image to include go #136

Merged
merged 1 commit into from Jul 13, 2022

Conversation

developer-guy
Copy link
Contributor

@developer-guy developer-guy commented Jul 13, 2022

Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com
Co-authored-by: Jason Hall jason@chainguard.dev

What type of PR is this?

/kind feature
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #135

Special notes for your reviewer:

After a quick chat with @imjasonh, thanks to him, we have agreed that the best way of providing a go binary for an image that is building with ko is changing the image's base with the one of the go binary installed. Fortunately, we have one, https://github.com/distroless/go. distroless.dev/go is an apko-built distroless image that includes go.

cc: @imjasonh

Does this PR introduce a user-facing change?

chore: use different base image to include go

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Co-authored-by: Jason Hall <jason@chainguard.dev>
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 13, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @developer-guy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 13, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 13, 2022
@puerco
Copy link
Member

puerco commented Jul 13, 2022

Thanks for the PR @developer-guy !
This is a great start! I think from here, the next step will be to build our own base image using apko to include more things beyond just go (such as git for example). But this should fix the broken go dependency problem for now! Thank you.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 13, 2022
@puerco
Copy link
Member

puerco commented Jul 13, 2022

Thanks @developer-guy @imjasonh !
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: developer-guy, puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 071fa29 into kubernetes-sigs:main Jul 13, 2022
@developer-guy
Copy link
Contributor Author

developer-guy commented Jul 13, 2022

That'd be great, and I'm also willing to help with this because I've played a bit with apko and melange to build a crane project with them recently.

@developer-guy
Copy link
Contributor Author

may I open an issue for this @puerco?

@justaugustus
Copy link
Member

may I open an issue for this @puerco?

@developer-guy -- Please do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker image for bom is broken
4 participants