-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor osinfo Container Scanner #329
Refactor osinfo Container Scanner #329
Conversation
b22ae98
to
d4c9504
Compare
This change starts to move individual OS type logic out to individual implementations and files.
d4c9504
to
4d6effb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
PTAL @puerco
/hold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks
/remove-label do-not-merge/hold |
@micahhausler: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-label hold |
@micahhausler: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @micahhausler ! It needed a refactor badly, it grew to the current Frankenstein slowly over the years and I had my eye on it for a while. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, micahhausler, puerco, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This change starts to move individual OS type logic out to individual implementations and files.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This change will make it easier to write and test new OS types for
bom generate --scan-images
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
I tried to keep the
osinfo
package API as close to the same as possible. I made thecontainerScanner
andlayerScanner
interfaces and their implementations internal to the package as they're not currently used externally.Does this PR introduce a user-facing change?