generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import boskos subdirectory from kubernetes/test-infra #1
Merged
k8s-ci-robot
merged 633 commits into
kubernetes-sigs:master
from
ixdy:merge-kubernetes-test-infra-boskos
May 15, 2020
Merged
Import boskos subdirectory from kubernetes/test-infra #1
k8s-ci-robot
merged 633 commits into
kubernetes-sigs:master
from
ixdy:merge-kubernetes-test-infra-boskos
May 15, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Delete SSL cert after target proxy to avoid in-use-by error
Updating Boskos to hold the lock when config is being synced
Add randomizer seed in boskoctl.
Delete vendor from test-infra
The sample defined a function that recursively called itself without ever doing anything else.
When the boskosctl command fails to send one heartbeat, it is not a catastrophic error as we send heartbeats much more frequently than strictly necessary to retain our lease. This allows us to keep an error budget and exit only when exceeding it, which is valuable as transitive network issues should not crash the heartbeat command. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Be more lenient with errors in heartbeats
Update prow to v20190911-0708557a1, and other images as necessary.
Revert listed Boskos version(s) to deployed images
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
Update error messages in boskos
Fix broken boskosctl sample
Move cleaner back to an example
Update prow to v20200501-dc40536ba, and other images as necessary.
Update prow to v20200507-36c6a27f0, and other images as necessary.
Update prow to v20200508-b3e98e45b, and other images as necessary.
Update prow to v20200511-c16c836df, and other images as necessary.
The boskos directory was filtered by running the following command inside kubernetes/test-infra: `git-filter-repo --subdirectory-filter boskos` The only merge conflicts were the OWNERS and README.md at top-level: - The existing OWNERS from kubernetes-sigs/boskos was used, rather than the one imported from kubernetes/test-infra. - I added the Community discussion and code of conduct sections from the template to the imported README.md.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ixdy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3228ba1
to
122b840
Compare
Merged
alvaroaleman
approved these changes
May 15, 2020
/lgtm |
Why does it not merge 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
sig/testing
Categorizes an issue or PR as relevant to SIG Testing.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
boskos
directory was filtered by running the following commandinside
kubernetes/test-infra
:git-filter-repo --subdirectory-filter boskos
The only merge conflicts were the
OWNERS
andREADME.md
at top-level:OWNERS
fromkubernetes-sigs/boskos
was used, rather thanthe one imported from k
ubernetes/test-infra
.the template to the imported
README.md
.I added one small commit to update the
README.md
to point to the right Slack channel and mailing list, but I haven't made any other changes yet; notably, this will fail to build./assign @alvaroaleman @stevekuznetsov