Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build images without bazel #8

Merged
merged 4 commits into from
May 21, 2020

Conversation

ixdy
Copy link
Contributor

@ixdy ixdy commented May 21, 2020

I mostly tried to keep the same functionality from the Bazel builds, but I made a few changes:

  • I renamed the cli image to boskosctl, since its referred to as boskosctl in all of the docs, and so seems more logical, but I can change that back. (@stevekuznetsov any thoughts?) I couldn't tell if anyone was using the existing gcr.io/k8s-prow/boskos/cli image.
  • I switched the aws-janitor images to distroless (from gcloud-in-go), since as far as I can tell, they don't need to shell out or call gcloud.
  • I've updated to explicitly require go1.14.3 (test-infra was most recently on go1.13.x). I don't think there's any harm in upgrading?
  • I've created a cloudbuild configuration for building images, since I think that's the recommended approach from the k8s.io infra working group. It should be easy to connect this to a prow job on postsubmit. (I've tested this locally using cloud-build-local.)

I'll remove Bazel in a follow-up PR. This one was already getting a bit large.

/assign @alvaroaleman

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 21, 2020
@alvaroaleman
Copy link
Member

I renamed the cli image to boskosctl, since its referred to as boskosctl in all of the docs, and so seems more logical, but I can change that back. (@stevekuznetsov any thoughts?) I couldn't tell if anyone was using the existing gcr.io/k8s-prow/boskos/cli image.

We mirror it but do not seem to actually be using it so thats fine. Not sure who else might be using it.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2020
@k8s-ci-robot k8s-ci-robot merged commit e6755e0 into kubernetes-sigs:master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants