fix: do not block creating route operation for unmanaged node when du…

…alstack is enabled. Signed-off-by: MartinForReal <fanshangxiang@gmail.com>
kubernetes-sigs · May 13, 2022 · 26d93a3 · 26d93a3
1 parent 490d288
commit 26d93a3
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 11 deletions.
diff --git a/pkg/provider/azure_routes.go b/pkg/provider/azure_routes.go
@@ -383,10 +383,6 @@ func (az *Cloud) CreateRoute(ctx context.Context, clusterName string, nameHint s
 		return err
 	}
 	if unmanaged {
-		if az.ipv6DualStackEnabled {
-			//TODO (khenidak) add support for unmanaged nodes when the feature reaches beta
-			return fmt.Errorf("unmanaged nodes are not supported in dual stack mode")
-		}
 		klog.V(2).Infof("CreateRoute: omitting unmanaged node %q", kubeRoute.TargetNode)
 		az.routeCIDRsLock.Lock()
 		defer az.routeCIDRsLock.Unlock()

diff --git a/pkg/provider/azure_routes_test.go b/pkg/provider/azure_routes_test.go
@@ -308,13 +308,6 @@ func TestCreateRoute(t *testing.T) {
 			routeCIDRs:         map[string]string{},
 			expectedRouteCIDRs: map[string]string{"node": "1.2.3.4/24"},
 		},
-		{
-			name:                 "CreateRoute should report error if node is unmanaged and cloud.ipv6DualStackEnabled is true",
-			hasUnmanagedNodes:    true,
-			ipv6DualStackEnabled: true,
-			unmanagedNodeName:    "node",
-			expectedErrMsg:       fmt.Errorf("unmanaged nodes are not supported in dual stack mode"),
-		},
 		{
 			name:           "CreateRoute should create route if cloud.ipv6DualStackEnabled is true and route doesn't exist",
 			routeTableName: "rt9",