remove auto approval restriction

pkg/provider/azure_privatelinkservice.go

@@ -451,11 +451,8 @@ func reconcilePLSVisibility(
 	service *v1.Service,
 ) (bool, error) {
 	changed := false
-	visibilitySubs, anyoneCanView := getPLSVisibility(service)
+	visibilitySubs, _ := getPLSVisibility(service)
 	autoApprovalSubs := getPLSAutoApproval(service)
-	if !anyoneCanView && len(autoApprovalSubs) > 0 {
-		return false, fmt.Errorf("reconcilePLSVisibility: autoApproval only takes effect when visibility is set to \"*\"")
-	}
 
 	if existingPLS.Visibility == nil || existingPLS.Visibility.Subscriptions == nil {
 		if len(visibilitySubs) != 0 {

pkg/provider/azure_privatelinkservice_test.go

@@ -1075,16 +1075,6 @@ func TestReconcilePLSVisibility(t *testing.T) {
 		assert.NoError(t, err)
 	})
 
-	t.Run("reconcilePLSVisibility should return error if visibility is not * but auto-approval is not empty", func(t *testing.T) {
-		annotations := map[string]string{
-			consts.ServiceAnnotationPLSVisibility:   "sub1 sub2",
-			consts.ServiceAnnotationPLSAutoApproval: "sub1",
-		}
-		service.Annotations = annotations
-		_, err := reconcilePLSVisibility(&pls, &service)
-		assert.Error(t, err)
-	})
-
 	t.Run("reconcilePLSVisibility should return not changed if both Visibility and autoApproval are same", func(t *testing.T) {
 		annotations := map[string]string{
 			consts.ServiceAnnotationPLSVisibility: "sub1 sub2",
@@ -1098,7 +1088,7 @@ func TestReconcilePLSVisibility(t *testing.T) {
 		assert.False(t, changed)
 	})
 
-	t.Run("reconcilePLSVisibility should return not changed if both Visibility and autoApproval are same", func(t *testing.T) {
+	t.Run("reconcilePLSVisibility should return not changed if both Visibility and autoApproval are same with *", func(t *testing.T) {
 		annotations := map[string]string{
 			consts.ServiceAnnotationPLSVisibility:   "*",
 			consts.ServiceAnnotationPLSAutoApproval: "sub1 sub2",