tags key is assumed to be case-sensitive

[feiskyer]

What happened:

According to Azure docs, A tag name can have a maximum of 512 characters and is case-insensitive. But the codes below are actually case-sensitive for tags key:

cloud-provider-azure/pkg/provider/azure_utils.go

Lines 130 to 146 in f749114

	// if the systemTags is not set, just add/update new currentTagsOnResource and not delete old currentTagsOnResource
	for k, v := range newTags {
	if vv, ok := currentTagsOnResource[k]; !ok || !strings.EqualFold(to.String(v), to.String(vv)) {
	currentTagsOnResource[k] = v
	changed = true
	}
	}
	// if the systemTags is set, delete the old currentTagsOnResource
	if len(systemTagsMap) > 0 {
	for k := range currentTagsOnResource {
	if _, ok := newTags[k]; !ok && !systemTagsMap.Has(k) {
	delete(currentTagsOnResource, k)
	changed = true
	}
	}
	}

What you expected to happen:

tags name should be case-insensitive. and if the tags have already been there, then existing tag name should be used.

How to reproduce it:

Anything else we need to know?:

Environment:

• Kubernetes version (use kubectl version): >=1.20
• OS (e.g. from /etc/os-release):
• Kernel (e.g. uname -a):
• Install tools:
• Others:

[feiskyer]

/assign @nilo19

Still need cherry-picking to kubernetes repo

[feiskyer]

Refer kubernetes/kubernetes#104705

[feiskyer]

cherry-pick PR has been merged.