Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make tags case-insensitive for both keys and values #669

Merged
merged 1 commit into from Jun 21, 2021
Merged

fix: make tags case-insensitive for both keys and values #669

merged 1 commit into from Jun 21, 2021

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Jun 19, 2021

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind bug

What this PR does / why we need it:

fix: make tags case-insensitive for both keys and values

Which issue(s) this PR fixes:

Fixes #658

Special notes for your reviewer:

Release note:

fix: make tags case-insensitive for both keys and values

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 19, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 19, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 79.373% when pulling 5e9c1c4 on nilo19:fix/tag-case into f2398fd on kubernetes-sigs:master.

feiskyer
feiskyer reviewed Jun 21, 2021
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cc2d89d into kubernetes-sigs:master Jun 21, 2021
@nilo19 nilo19 deleted the fix/tag-case branch June 21, 2021 02:04
k8s-ci-robot added a commit that referenced this pull request Jun 21, 2021
@k8s-ci-robot
Merge pull request #672 from feiskyer/tags
ef01976 
cherry-pick of #669: make tags case-insensitive for both keys and values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tags key is assumed to be case-sensitive
4 participants
@nilo19 @coveralls @k8s-ci-robot @feiskyer