Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support special characters in tags #887

Closed
feiskyer opened this issue Oct 29, 2021 · 0 comments · Fixed by #892
Closed

Support special characters in tags #887

feiskyer opened this issue Oct 29, 2021 · 0 comments · Fixed by #892
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@feiskyer
Copy link
Member

What would you like to be added:

Refer https://kubernetes-sigs.github.io/cloud-provider-azure/topics/tagging-resources/, because of the configuration format "tags": "a=b,c=d",, special characters = and , couldn't be used directly the tags configuration.

To support random characters in the tags, key-value pairs should be allowed in the configuration tags and systemTags.

Why is this needed:

Azure tags support special characters in both key and value, hence cloud provider should provide consistent behavior with that.
@feiskyer feiskyer added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 29, 2021
@nilo19 nilo19 mentioned this issue Nov 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support json style tags
1 participant
@feiskyer