Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support json style tags #892

Merged
merged 1 commit into from Nov 9, 2021
Merged

feat: support json style tags #892

merged 1 commit into from Nov 9, 2021

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Nov 5, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:

Normally we don't support special characters such as = or , in key-value pairs. These characters will be treated as separator and will not be included in the key/value literal. To solve this problem, tagsMap is introduced, in which a JSON-style tag is acceptable.

{
  "tags": "a=b,c=d",
  "tagsMap": {"e": "f", "g=h": "i,j"}
}

tags and tagsMap will be merged, and similarly, they are case-insensitive.

Which issue(s) this PR fixes:

Fixes #887

Special notes for your reviewer:

Does this PR introduce a user-facing change?

feat: support json style tags

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 5, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2021
@coveralls
Copy link

coveralls commented Nov 5, 2021

Coverage Status

Coverage decreased (-0.0002%) to 80.374% when pulling 2b1aee9 on nilo19:feat/tag-map into 46f2c54 on kubernetes-sigs:master.

@nilo19
Copy link
Contributor Author

nilo19 commented Nov 5, 2021

/retest

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 8, 2021
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer
Copy link
Member

feiskyer commented Nov 8, 2021

/retest

2 similar comments
@nilo19
Copy link
Contributor Author

nilo19 commented Nov 8, 2021

/retest

@nilo19
Copy link
Contributor Author

nilo19 commented Nov 9, 2021

/retest

@k8s-ci-robot k8s-ci-robot merged commit f804778 into kubernetes-sigs:master Nov 9, 2021
@nilo19 nilo19 deleted the feat/tag-map branch November 9, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support special characters in tags
4 participants