Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test_k8s_e2e_capz.sh #1077

Merged
merged 1 commit into from Jan 29, 2022
Merged

Add test_k8s_e2e_capz.sh #1077

merged 1 commit into from Jan 29, 2022

Conversation

lzhecheng
Copy link
Contributor

@lzhecheng lzhecheng commented Jan 28, 2022 •
edited by MartinForReal

  • test_k8s_e2e_capz.sh is for tests with capz
  • It fits TOT capz, test-infra and kubernetes
  • Add exec permission for test_k8s_e2e*.sh

Signed-off-by: Zhecheng Li zhechengli@microsoft.com

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 28, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @lzhecheng. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 28, 2022
@lzhecheng
Copy link
Contributor Author

This PR is a prerequisite of kubernetes/test-infra#24935

@coveralls
Copy link

coveralls commented Jan 28, 2022 •
edited

Coverage Status

Coverage remained the same at 80.007% when pulling e09df67 on lzhecheng:fix-make-test-e2e into dd8d6a6 on kubernetes-sigs:master.

MartinForReal
MartinForReal reviewed Jan 28, 2022
View reviewed changes
hack/test_k8s_e2e.sh Outdated
else
echo "KUBECONFIG not set"
exit 1
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if cluster is provisioned using aks-engine, kubeconfig can be found under REPOROOT/_output/dnsprefix/kubeconfig/xxxx.json.
I don't think we need to set KUBECONFIG here.

Copy link
Contributor Author

@lzhecheng lzhecheng Jan 28, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this change is for tests migration to capz.
If test_k8s_e2e.sh is used by aks-engine then I need to reconsider the change to fit both.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to simply add a new script for capz because anyway the one for aks-engine will be deprecated. I think there's unnecessary to bother adding options or env var checks in original script.

@feiskyer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 28, 2022
@lzhecheng lzhecheng force-pushed the fix-make-test-e2e branch 2 times, most recently from 590be91 to b7730b2 Compare January 28, 2022 05:36
@lzhecheng
Add test_k8s_e2e_capz.sh
e09df67 
* test_k8s_e2e_capz.sh is for tests with capz
* It fits TOT capz, test-infra and kubernetes
* Add exec permission for test_k8s_e2e*.sh

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
@lzhecheng lzhecheng changed the title Adjust test_k8s_e2e.sh Add test_k8s_e2e_capz.sh Jan 28, 2022
@MartinForReal
Copy link
Contributor

/retest

@MartinForReal
Copy link
Contributor

/label release-note-none

@k8s-ci-robot
Copy link
Contributor

@MartinForReal: The label(s) /label release-note-none cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor

In response to this:

/label release-note-none

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 29, 2022
@MartinForReal
Copy link
Contributor

/lgtm
/assign @nilo19

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2022
feiskyer
feiskyer approved these changes Jan 29, 2022
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, lzhecheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2022
@lzhecheng
Copy link
Contributor Author

/test pull-cloud-provider-azure-e2e-ccm-capz

1 similar comment
@lzhecheng
Copy link
Contributor Author

/test pull-cloud-provider-azure-e2e-ccm-capz

@k8s-ci-robot k8s-ci-robot merged commit 65a9cad into kubernetes-sigs:master Jan 29, 2022
@lzhecheng lzhecheng deleted the fix-make-test-e2e branch January 30, 2022 01:05
This was referenced Feb 10, 2022
Closed
Closed
@lzhecheng
Copy link
Contributor Author

/cherry-pick release-1.23

@k8s-infra-cherrypick-robot
Copy link

@lzhecheng: only kubernetes-sigs org members may request cherry picks. You can still do the cherry-pick manually.

In response to this:

/cherry-pick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nilo19
Copy link
Contributor

nilo19 commented Feb 10, 2022

/cherry-pick release-1.23

@nilo19
Copy link
Contributor

nilo19 commented Feb 10, 2022

/cherry-pick release-1.1

@nilo19
Copy link
Contributor

nilo19 commented Feb 10, 2022

/cherry-pick release-1.0

@nilo19
Copy link
Contributor

nilo19 commented Feb 10, 2022

/cherry-pick release-0.7

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 10, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@nilo19: new pull request created: #1132

In response to this:

/cherry-pick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 10, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@nilo19: new pull request created: #1133

In response to this:

/cherry-pick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 10, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@nilo19: new pull request created: #1134

In response to this:

/cherry-pick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 10, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@nilo19: new pull request created: #1135

In response to this:

/cherry-pick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinForReal MartinForReal MartinForReal left review comments

@feiskyer feiskyer feiskyer approved these changes

Assignees

@feiskyer feiskyer

@MartinForReal MartinForReal

@nilo19 nilo19

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@lzhecheng @k8s-ci-robot @coveralls @feiskyer @MartinForReal @k8s-infra-cherrypick-robot @nilo19