Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.23] feat: support changing LB backend pool type between nodeIP and nodeIP… #1125

Merged
merged 1 commit into from Feb 10, 2022
Merged

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Feb 10, 2022

…Configuration in existing clusters

(cherry picked from commit 12ba814)

What type of PR is this?

/kind feature

What this PR does / why we need it:

Cherry pick of #1034 to release-1.23: feat: support changing LB backend pool type between nodeIP and nodeIPConfiguration in existing clusters

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

feat: support changing LB backend pool type between nodeIP and nodeIP…

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


…Configuration in existing clusters

(cherry picked from commit 12ba814)
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 80.039% when pulling 7fa5ca9 on nilo19:feat/cherry-pick-1034-1.23 into e58d16b on kubernetes-sigs:release-1.23.

@MartinForReal
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit c474d43 into kubernetes-sigs:release-1.23 Feb 10, 2022
@nilo19 nilo19 deleted the feat/cherry-pick-1034-1.23 branch February 10, 2022 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants