Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.23]fix: fallback to tcp if appprotocol is not supported #1394

Merged
merged 1 commit into from Apr 1, 2022
Merged

[release-1.23]fix: fallback to tcp if appprotocol is not supported #1394

merged 1 commit into from Apr 1, 2022

Conversation

MartinForReal
Copy link
Contributor

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

Fall back to tcp if user assigned probe protocol is not supported.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The cloud provider will create TCP probe rule if the probe protocol is not supported.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 1, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2022
@MartinForReal
fix: fallback to tcp if appprotocol is not supported
c941dc2 
Signed-off-by: MartinForReal <fanshangxiang@gmail.com>
@MartinForReal MartinForReal changed the title [releas-1.23]fix: fallback to tcp if appprotocol is not supported [release-1.23]fix: fallback to tcp if appprotocol is not supported Apr 1, 2022
@MartinForReal
Copy link
Contributor Author

/retest

@lzhecheng
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lzhecheng, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MartinForReal,lzhecheng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MartinForReal
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 4d048d4 into kubernetes-sigs:release-1.23 Apr 1, 2022
@MartinForReal MartinForReal deleted the release-1.23/backport_1384 branch April 18, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzhecheng lzhecheng Awaiting requested review from lzhecheng

@nilo19 nilo19 Awaiting requested review from nilo19

Assignees

@lzhecheng lzhecheng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MartinForReal @lzhecheng @k8s-ci-robot