Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.0] fix(instance-v2): use false<bool> representing ErrInstanceNotFound<errror> #1511

Merged
merged 2 commits into from Apr 18, 2022
Merged

[release-1.0] fix(instance-v2): use false<bool> representing ErrInstanceNotFound<errror> #1511

merged 2 commits into from Apr 18, 2022

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #1507

/assign feiskyer

fix InstanceV2.InstanceExists: it should return false<bool> instead of ErrInstanceNotFound<error>

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 18, 2022
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 18, 2022
Merged
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 18, 2022
feiskyer
feiskyer reviewed Apr 18, 2022
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 80.202% when pulling c8bbb7a on k8s-infra-cherrypick-robot:cherry-pick-1507-to-release-1.0 into 5b6bc04 on kubernetes-sigs:release-1.0.

@MartinForReal
Copy link
Contributor

/test pull-cloud-provider-azure-e2e-ccm-capz-1-21

@k8s-ci-robot k8s-ci-robot merged commit 482cdc3 into kubernetes-sigs:release-1.0 Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@lzhecheng lzhecheng Awaiting requested review from lzhecheng

@MartinForReal MartinForReal Awaiting requested review from MartinForReal

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@k8s-infra-cherrypick-robot @k8s-ci-robot @coveralls @MartinForReal @feiskyer @zarvd