Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.1] Upgrade network API version to 2021-08-01 #1786

Merged
merged 1 commit into from Jun 7, 2022
Merged

[release-1.1] Upgrade network API version to 2021-08-01 #1786

merged 1 commit into from Jun 7, 2022

Conversation

zarvd
Copy link
Contributor

@zarvd zarvd commented May 30, 2022 •
edited by feiskyer

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

cherry pick #1765 to release-1.1

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

chore: upgrade network API version to 2021-08-01

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 30, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @lodrem. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 30, 2022
@coveralls
Copy link

coveralls commented May 30, 2022 •
edited

Coverage Status

Coverage remained the same at 80.677% when pulling 3ee9baa on lodrem:feat/upgrade-network-api-release-1.1 into c5e496e on kubernetes-sigs:release-1.1.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels May 30, 2022
@feiskyer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 30, 2022
@zarvd
Copy link
Contributor Author

zarvd commented May 30, 2022

/test pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-22

@zarvd
Copy link
Contributor Author

zarvd commented May 31, 2022

/retest

@lzhecheng
Copy link
Contributor

/test pull-cloud-provider-azure-e2e-ccm-capz-1-22

@zarvd zarvd force-pushed the feat/upgrade-network-api-release-1.1 branch from 32f327f to 3ee9baa Compare June 2, 2022 05:18
@MartinForReal
Copy link
Contributor

/test pull-cloud-provider-azure-e2e-ccm-capz-1-22

@feiskyer
Copy link
Member

feiskyer commented Jun 7, 2022

/retest
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, lodrem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit 66ef8e5 into kubernetes-sigs:release-1.1 Jun 7, 2022
@zarvd zarvd deleted the feat/upgrade-network-api-release-1.1 branch June 7, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzhecheng lzhecheng Awaiting requested review from lzhecheng

@MartinForReal MartinForReal Awaiting requested review from MartinForReal

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zarvd @k8s-ci-robot @coveralls @feiskyer @lzhecheng @MartinForReal