Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.23] fix: avoid unnessary NSG updating on service reconciling #1853

Merged
merged 2 commits into from Jun 17, 2022
Merged

[release-1.23] fix: avoid unnessary NSG updating on service reconciling #1853

merged 2 commits into from Jun 17, 2022

Conversation

feiskyer
Copy link
Member

This is an automated cherry-pick of #1845

/kind bug

fix: avoid unnessary NSG updating on service reconciling

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 80.533% when pulling 0baefc7 on feiskyer:nsg1.23 into 8702653 on kubernetes-sigs:release-1.23.

@feiskyer
Copy link
Member Author

/retest

@nilo19
Copy link
Contributor

nilo19 commented Jun 17, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 17, 2022
@k8s-ci-robot k8s-ci-robot merged commit f822632 into kubernetes-sigs:release-1.23 Jun 17, 2022
@feiskyer feiskyer deleted the nsg1.23 branch June 17, 2022 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzhecheng lzhecheng Awaiting requested review from lzhecheng

@nilo19 nilo19 Awaiting requested review from nilo19

Assignees

@nilo19 nilo19

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@feiskyer @k8s-ci-robot @coveralls @nilo19