Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.0] fix: remove auto approval restriction #1870

Merged
merged 1 commit into from Jun 18, 2022
Merged

[release-1.0] fix: remove auto approval restriction #1870

merged 1 commit into from Jun 18, 2022

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #1863

/assign jwtty

Remove redundant restriction on pls autoApproval and visibility.
User can specify a list of subscriptions for visibility (e.g. "sub1 sub2") and a subset of this list for autoApproval (e.g. "sub1").

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 18, 2022
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 18, 2022
@jwtty
Copy link
Member

jwtty commented Jun 18, 2022

/king bug
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwtty, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 80.394% when pulling eddb31c on k8s-infra-cherrypick-robot:cherry-pick-1863-to-release-1.0 into fc8e1d3 on kubernetes-sigs:release-1.0.

@lzhecheng
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 18, 2022
@lzhecheng
Copy link
Contributor

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind labels Jun 18, 2022
@lzhecheng
Copy link
Contributor

/retest

1 similar comment
@jwtty
Copy link
Member

jwtty commented Jun 18, 2022

/retest

@jwtty
Copy link
Member

jwtty commented Jun 18, 2022

/test pull-cloud-provider-azure-e2e-ccm-capz-1-21

@k8s-ci-robot k8s-ci-robot merged commit 320abd4 into kubernetes-sigs:release-1.0 Jun 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@lzhecheng lzhecheng Awaiting requested review from lzhecheng

Assignees

@lzhecheng lzhecheng

@jwtty jwtty

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@k8s-infra-cherrypick-robot @jwtty @k8s-ci-robot @coveralls @lzhecheng