Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.0] Cherrypick 1864 1865 #1876

Merged
merged 6 commits into from Jun 19, 2022
Merged

[release-1.0] Cherrypick 1864 1865 #1876

merged 6 commits into from Jun 19, 2022

Conversation

lzhecheng
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Cherrypick 1864 1865

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 19, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lzhecheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.394% when pulling 0bfe96c on lzhecheng:cp-r-1.0-1864-1865 into 1ef9b50 on kubernetes-sigs:release-1.0.

@jwtty
Copy link
Member

jwtty commented Jun 19, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2022
@jwtty
Copy link
Member

jwtty commented Jun 19, 2022

/test pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-21

1 similar comment
@jwtty
Copy link
Member

jwtty commented Jun 19, 2022

/test pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-21

@k8s-ci-robot k8s-ci-robot merged commit 78ce9a6 into kubernetes-sigs:release-1.0 Jun 19, 2022
@lzhecheng lzhecheng deleted the cp-r-1.0-1864-1865 branch June 19, 2022 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@jwtty jwtty Awaiting requested review from jwtty

Assignees

@jwtty jwtty

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lzhecheng @k8s-ci-robot @coveralls @jwtty @zarvd