Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.23] Improve the error handling for ARM APIs #1955

Merged
merged 1 commit into from Jun 30, 2022

Conversation

lzhecheng
Copy link
Contributor

For replication latency, it is possible contentLength is 0 and http
status code is 200

Signed-off-by: Zhecheng Li zhechengli@microsoft.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Improve the error handling for ARM APIs. For replication latency, it is possible contentLength is 0 and http
status code is 200

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Improve the error handling for ARM APIs. For replication latency, it is possible contentLength is 0 and http
status code is 200

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 29, 2022
@lzhecheng lzhecheng changed the title Improve the error handling for ARM APIs [release-1.23] Improve the error handling for ARM APIs Jun 29, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 29, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lzhecheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2022
For replication latency, it is possible contentLength is 0 and http
status code is 200

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
@coveralls
Copy link

coveralls commented Jun 29, 2022

Coverage Status

Coverage increased (+0.04%) to 80.553% when pulling 9b05bf6 on lzhecheng:cp-r-1.23-1400 into 8855882 on kubernetes-sigs:release-1.23.

@lzhecheng
Copy link
Contributor Author

/retest

@nilo19
Copy link
Contributor

nilo19 commented Jun 29, 2022

/lgtm

1 similar comment
@jwtty
Copy link
Member

jwtty commented Jun 30, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit e421603 into kubernetes-sigs:release-1.23 Jun 30, 2022
@lzhecheng lzhecheng deleted the cp-r-1.23-1400 branch February 17, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants