Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some log info to gain insight into some failure cases. #198

Merged
merged 1 commit into from
Jul 26, 2019
Merged

Add some log info to gain insight into some failure cases. #198

merged 1 commit into from
Jul 26, 2019

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Jul 26, 2019

Add some log info to gain insight into some failure cases.

/sig testing

Release note:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 26, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @nilo19. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 26, 2019
@acs-bot
Copy link
Collaborator

acs-bot commented Jul 26, 2019

Hi @nilo19. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

feiskyer
feiskyer reviewed Jul 26, 2019
View reviewed changes
tests/e2e/network/ensureloadbalancer.go Outdated
Expect(errList).NotTo(HaveOccurred())
By("Events list:")
for i, event := range list.Items {
By(fmt.Sprintf("%d. %v", i, event))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you use utils.Logf for logs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

justaugustus
justaugustus requested changes Jul 26, 2019
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to remove the fmt.Sprintfs. I made some code suggestions.
@feiskyer -- let me know if that looks right.

tests/e2e/network/ensureloadbalancer.go Outdated
Expect(errList).NotTo(HaveOccurred())
utils.Logf("Events list:")
for i, event := range list.Items {
utils.Logf(fmt.Sprintf("%d. %v", i, event))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
utils.Logf(fmt.Sprintf("%d. %v", i, event))
utils.Logf("%d. %v", i, event)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fmt.Sprintf is redundant. I'll amend it. Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense. please remove the fmt

tests/e2e/network/ensureloadbalancer.go Outdated Show resolved Hide resolved
@justaugustus
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 26, 2019
@justaugustus
Copy link
Member

@feiskyer -- as an aside, why are we using @acs-bot here?

@feiskyer
Copy link
Member

feiskyer commented Jul 26, 2019 •
edited
Loading

@justaugustus acs-bot is used to setup http://prow.upstream.azure-containers.io/. We're using this prow to validate and troubleshoot some e2e tests.

@nilo19
Copy link
Contributor Author

nilo19 commented Jul 26, 2019

/retest

@justaugustus
Copy link
Member

@nilo19 -- you need to gofmt that file. The tests are failing because fmt is still in the import declaration and it is unused:

W0726 09:32:27.092] tests/e2e/network/ensureloadbalancer.go:20:2: imported and not used: "fmt"

@nilo19
Copy link
Contributor Author

nilo19 commented Jul 26, 2019

@nilo19 -- you need to gofmt that file. The tests are failing because fmt is still in the import declaration and it is unused:

W0726 09:32:27.092] tests/e2e/network/ensureloadbalancer.go:20:2: imported and not used: "fmt"

Got it. Thank you very much.

@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2019
feiskyer
feiskyer reviewed Jul 26, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, justaugustus, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit d1efa3d into kubernetes-sigs:master Jul 26, 2019
@nilo19 nilo19 mentioned this pull request Aug 19, 2019
Closed
6 tasks
@nilo19 nilo19 deleted the t-qini-fix_timeout branch August 17, 2020 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@justaugustus justaugustus justaugustus requested changes

Assignees

@justaugustus justaugustus

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nilo19 @k8s-ci-robot @acs-bot @justaugustus @feiskyer