Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.24] fix: Ignore privateIPAllocationMethod when comparing frontend config #2001

Merged
merged 1 commit into from Jul 12, 2022
Merged

[release-1.24] fix: Ignore privateIPAllocationMethod when comparing frontend config #2001

merged 1 commit into from Jul 12, 2022

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #1991

/assign jwtty

Fix: Do not compare privateIPAllocationMethod when checking if frontend config needs update. Just check if frontend ip matches service spec to avoid unnecessary LB frontend recreation.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 9, 2022
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind labels Jul 9, 2022
@k8s-ci-robot k8s-ci-robot requested review from jwtty and nilo19 July 9, 2022 05:15
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 9, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 79.85% when pulling 33e375c on k8s-infra-cherrypick-robot:cherry-pick-1991-to-release-1.24 into 4238b21 on kubernetes-sigs:release-1.24.

@jwtty
Copy link
Member

jwtty commented Jul 9, 2022

/approve
/lgtm
/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/needs-kind labels Jul 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwtty, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2022
@jwtty
Copy link
Member

jwtty commented Jul 9, 2022

/retest

2 similar comments
@jwtty
Copy link
Member

jwtty commented Jul 9, 2022

/retest

@jwtty
Copy link
Member

jwtty commented Jul 10, 2022

/retest

@jwtty
Copy link
Member

jwtty commented Jul 11, 2022

/test pull-cloud-provider-azure-e2e-ccm-capz-1-24
/test pull-cloud-provider-azure-e2e-capz-1-24

@jwtty
Copy link
Member

jwtty commented Jul 11, 2022

/retest

@nilo19 nilo19 added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/bug Categorizes issue or PR as related to a bug. labels Jul 11, 2022
@jwtty
Copy link
Member

jwtty commented Jul 12, 2022

/test pull-cloud-provider-azure-e2e-ccm-capz-1-24
/test pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-24

@jwtty
Copy link
Member

jwtty commented Jul 12, 2022

/test pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-24

1 similar comment
@jwtty
Copy link
Member

jwtty commented Jul 12, 2022

/test pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-24

@k8s-ci-robot k8s-ci-robot merged commit ba5858d into kubernetes-sigs:release-1.24 Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwtty jwtty Awaiting requested review from jwtty

@nilo19 nilo19 Awaiting requested review from nilo19

Assignees

@jwtty jwtty

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@k8s-infra-cherrypick-robot @coveralls @jwtty @k8s-ci-robot @nilo19