Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release 1.1] Add detailed error reuslt_code in ObserveOperationWithR… #2025

Merged
merged 1 commit into from Jul 14, 2022
Merged

[release 1.1] Add detailed error reuslt_code in ObserveOperationWithR… #2025

merged 1 commit into from Jul 14, 2022

Conversation

lanlou1554
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

When errors happen, the current result_code is always "failed" in ObserveOperationWithResult func.
Now the result_code turns to something like "failed_create_route", "failed_ensure_loadbalancer" and so on.

Which issue(s) this PR fixes:

Fixes #1986

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Result_code in latency logs is more detailed.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 14, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @monianshouhou. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 14, 2022
lanlou1554
lanlou1554 commented Jul 14, 2022
View reviewed changes
pkg/metrics/azure_metrics.go
@@ -99,6 +99,9 @@ func (mc *MetricContext) ObserveOperationWithResult(isOperationSucceeded bool, l
resultCode := "succeeded"
if !isOperationSucceeded {
resultCode = "failed"
if len(mc.attributes) > 0 {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UT test needs 1.2.0 logr, so UT test is temporarily removed and will be added in the future.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 80.633% when pulling 836a9f6 on monianshouhou:detailed_latency_log_release1.1 into e1b2b0a on kubernetes-sigs:release-1.1.

@MartinForReal
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 14, 2022
@MartinForReal
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MartinForReal, monianshouhou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit b1322f5 into kubernetes-sigs:release-1.1 Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwtty jwtty Awaiting requested review from jwtty

@MartinForReal MartinForReal Awaiting requested review from MartinForReal

Assignees

@MartinForReal MartinForReal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lanlou1554 @k8s-ci-robot @coveralls @MartinForReal