Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.24] Fix PIP tags possibly not ensured issue in ensurePublicIPExists() #2048

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #2040

/assign lzhecheng

Fix PIP tags possibly not ensured issue in ensurePublicIPExists()

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 18, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 79.955% when pulling c434fa7 on k8s-infra-cherrypick-robot:cherry-pick-2040-to-release-1.24 into 0ad45e4 on kubernetes-sigs:release-1.24.

@lzhecheng
Copy link
Contributor

/retest
/kind bug
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/needs-kind labels Jul 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, lzhecheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2022
@lzhecheng
Copy link
Contributor

/retest

1 similar comment
@lzhecheng
Copy link
Contributor

/retest

@lzhecheng
Copy link
Contributor

/test pull-cloud-provider-azure-e2e-ccm-capz-1-24

@k8s-ci-robot k8s-ci-robot merged commit 4225fc4 into kubernetes-sigs:release-1.24 Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants