Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases for standard load balancer. #207

Merged
merged 1 commit into from
Aug 7, 2019
Merged

Add test cases for standard load balancer. #207

merged 1 commit into from
Aug 7, 2019

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Aug 5, 2019

Add test cases for standard load balancer.

Partly fixes issue #181

Release note:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 5, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @nilo19. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 5, 2019
@acs-bot
Copy link
Collaborator

acs-bot commented Aug 5, 2019

Hi @nilo19. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

feiskyer
feiskyer reviewed Aug 5, 2019
View reviewed changes
tests/e2e/network/standard_lb.go Outdated
ns = nil
})

It("should add all nodes in different agent pools should to backends [MultipleAgentPools]", func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/should to backends/to backends/

feiskyer
feiskyer reviewed Aug 5, 2019
View reviewed changes
tests/e2e/utils/azure_auth.go Outdated

// IsStandardLoadBalancer judges whether the load balancer sku config is standard
func IsStandardLoadBalancer() bool {
return os.Getenv(LoadBalancerSkuEnv) == "standard"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can actually get the sku from SLB.sku.name == Standard

feiskyer
feiskyer reviewed Aug 5, 2019
View reviewed changes
tests/e2e/network/standard_lb.go
ns = nil
})

It("should add all nodes in different agent pools to backends [MultipleAgentPools]", func() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L89 could be moved here, and then use lb.sku.Name to check whether it's Standard LB.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember use strings.EqualFold() instead of ==

@feiskyer
Copy link
Member

feiskyer commented Aug 6, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 6, 2019
feiskyer
feiskyer reviewed Aug 6, 2019
View reviewed changes
tests/e2e/network/standard_lb.go Outdated
publicIP := createServiceWithAnnotation(cs, serviceName, ns.Name, labels, map[string]string{}, ports)
lb := getAzureLoadBalancerFromPIP(publicIP, rgName, rgName)

if strings.EqualFold(string(lb.Sku.Name), "standard") != true {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ! instead.

feiskyer
feiskyer reviewed Aug 7, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit d354ff7 into kubernetes-sigs:master Aug 7, 2019
@nilo19 nilo19 mentioned this pull request Aug 19, 2019
Closed
6 tasks
@nilo19 nilo19 deleted the t-qini-verify_stadnard_lb branch August 17, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nilo19 @k8s-ci-robot @acs-bot @feiskyer