Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.23] Allow external service with floating ip disabled to use PLS #2077

Merged
merged 1 commit into from Jul 26, 2022
Merged

[release-1.23] Allow external service with floating ip disabled to use PLS #2077

merged 1 commit into from Jul 26, 2022

Conversation

jwtty
Copy link
Member

@jwtty jwtty commented Jul 25, 2022 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Allow external service with floating ip disabled to create PLS.

Which issue(s) this PR fixes:

Fixes #
related #2073

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Allow external service with floating ip disabled to create PLS.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwtty

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from nilo19 July 25, 2022 13:50
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 80.478% when pulling 3413a25 on jwtty:cp_pls_1.23 into 691ad77 on kubernetes-sigs:release-1.23.

@lzhecheng
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0411584 into kubernetes-sigs:release-1.23 Jul 26, 2022
@jwtty jwtty deleted the cp_pls_1.23 branch July 26, 2022 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinForReal MartinForReal Awaiting requested review from MartinForReal

@nilo19 nilo19 Awaiting requested review from nilo19

Assignees

@lzhecheng lzhecheng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jwtty @k8s-ci-robot @coveralls @lzhecheng