Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.23] Use correct subnet name in reconcileFrontendIPConfigs() #2082

Merged
merged 1 commit into from Aug 1, 2022
Merged

[release-1.23] Use correct subnet name in reconcileFrontendIPConfigs() #2082

merged 1 commit into from Aug 1, 2022

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #2076

/assign lzhecheng

Use correct subnet name in reconcileFrontendIPConfigs()

@lzhecheng
Use correct subnet name in reconcileFrontendIPConfigs()
838f280 
Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 25, 2022
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 25, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.477% when pulling 838f280 on k8s-infra-cherrypick-robot:cherry-pick-2076-to-release-1.23 into 691ad77 on kubernetes-sigs:release-1.23.

@lzhecheng
Copy link
Contributor

/retest
/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind labels Jul 26, 2022
@jwtty
Copy link
Member

jwtty commented Jul 26, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwtty, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2022
@lzhecheng
Copy link
Contributor

/retest

1 similar comment
@lzhecheng
Copy link
Contributor

/retest

@lzhecheng
Copy link
Contributor

/test pull-cloud-provider-azure-e2e-ccm-vmss-capz-1-23

@lzhecheng
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit bb3c2ad into kubernetes-sigs:release-1.23 Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@jwtty jwtty Awaiting requested review from jwtty

Assignees

@lzhecheng lzhecheng

@jwtty jwtty

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@k8s-infra-cherrypick-robot @coveralls @lzhecheng @jwtty @k8s-ci-robot