Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs for two cloud configurations. #213

Merged
merged 1 commit into from
Aug 9, 2019
Merged

Add docs for two cloud configurations. #213

merged 1 commit into from
Aug 9, 2019

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Aug 9, 2019

/kind documentation

Add docs for two cloud configurations.

Release note:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @nilo19. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 9, 2019
@acs-bot
Copy link
Collaborator

acs-bot commented Aug 9, 2019

Hi @nilo19. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feiskyer
Copy link
Member

feiskyer commented Aug 9, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 9, 2019
feiskyer
feiskyer reviewed Aug 9, 2019
View reviewed changes
docs/cloud-provider-config.md Outdated
@@ -80,6 +80,8 @@ If more than one value is set, the order is `Managed Identity` > `Service Princi
|cloudProviderRateLimitBucketWrite|Rate limit Bucket Size|Integer value, valid if `cloudProviderRateLimit` is true|
|useInstanceMetadata|Use instance metadata service where possible|Boolean value, default to false|
|loadBalancerSku|Sku of Load Balancer and Public IP. Candidate values are: `basic` and `standard`.|Default to `basic`.|
|loadBalancerResourceGroup|Resource group name of the load balancer user want to use, default value is the name of cluster's resource group|String value of rg's name, optional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing | at the end

@nilo19
Copy link
Contributor Author

nilo19 commented Aug 9, 2019

/test pull-cloud-provider-azure-e2e-ccm

1 similar comment
@feiskyer
Copy link
Member

feiskyer commented Aug 9, 2019

/test pull-cloud-provider-azure-e2e-ccm

@feiskyer
Copy link
Member

feiskyer commented Aug 9, 2019

let's see whether #214 could help to fix the e2e errors

@feiskyer
Copy link
Member

feiskyer commented Aug 9, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit c588d51 into kubernetes-sigs:master Aug 9, 2019
@nilo19 nilo19 mentioned this pull request Aug 19, 2019
Closed
6 tasks
@nilo19 nilo19 deleted the t-qini_add_cross_rg_lb_doc branch August 17, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@karataliu karataliu Awaiting requested review from karataliu

@khenidak khenidak Awaiting requested review from khenidak

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nilo19 @k8s-ci-robot @acs-bot @feiskyer