Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.24] fix: NSG destination IP version same as LB IP for floating ip disabled services #2239

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #2230

/assign jwtty

Fix nsg reconciliation failure for floating-ip-disabled services in dual-stack clusters.

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 31, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 31, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 79.97% when pulling e77c1ff on k8s-infra-cherrypick-robot:cherry-pick-2230-to-release-1.24 into fc2064f on kubernetes-sigs:release-1.24.

@jwtty
Copy link
Member

jwtty commented Aug 31, 2022

/kind bug
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/needs-kind labels Aug 31, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwtty, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2022
@jwtty
Copy link
Member

jwtty commented Aug 31, 2022

/test pull-cloud-provider-azure-e2e-ccm-capz-1-24

1 similar comment
@jwtty
Copy link
Member

jwtty commented Aug 31, 2022

/test pull-cloud-provider-azure-e2e-ccm-capz-1-24

@k8s-ci-robot k8s-ci-robot merged commit 9efe2bb into kubernetes-sigs:release-1.24 Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants