Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.25] chore: get node private IPs from cache but NIC #2433

Merged
merged 1 commit into from Sep 30, 2022
Merged

[release-1.25] chore: get node private IPs from cache but NIC #2433

merged 1 commit into from Sep 30, 2022

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #2430

/assign nilo19

chore: get node private IPs from cache but NIC

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 29, 2022
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Sep 29, 2022
Merged
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 29, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 80.401% when pulling a3fa699 on k8s-infra-cherrypick-robot:cherry-pick-2430-to-release-1.25 into 808df62 on kubernetes-sigs:release-1.25.

@nilo19
Copy link
Contributor

nilo19 commented Sep 30, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 30, 2022
@nilo19 nilo19 added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 30, 2022
@feiskyer
Copy link
Member

/lgtm

@nilo19
Copy link
Contributor

nilo19 commented Sep 30, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2022
@nilo19 nilo19 merged commit 6883036 into kubernetes-sigs:release-1.25 Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwtty jwtty Awaiting requested review from jwtty

@lzhecheng lzhecheng Awaiting requested review from lzhecheng

Assignees

@feiskyer feiskyer

@nilo19 nilo19

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@k8s-infra-cherrypick-robot @coveralls @nilo19 @feiskyer @k8s-ci-robot