Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should update dns label if target pip already have one and it needs update #2665

Merged
merged 2 commits into from Nov 3, 2022
Merged

fix: should update dns label if target pip already have one and it needs update #2665

merged 2 commits into from Nov 3, 2022

Conversation

MartinForReal
Copy link
Contributor

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

fix: should update dns label if target pip already have one and it needs update

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix an issue when DNS label of public ip is not updated when service.beta.kubernetes.io/azure-dns-label-name is changed.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 31, 2022
@netlify
Copy link

netlify bot commented Oct 31, 2022 •
edited

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

Name Link
🔨 Latest commit 2a942d1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/6362916a22bf0800098083e8

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 31, 2022
@MartinForReal
fix: should update dns label if target pip already have one and its v…
8575eb9 
…alue is different

Signed-off-by: MartinForReal <fanshangxiang@gmail.com>
@coveralls
Copy link

coveralls commented Oct 31, 2022 •
edited

Coverage Status

Coverage increased (+0.02%) to 79.857% when pulling 2a942d1 on MartinForReal:fixdnslabel into ba8cbaa on kubernetes-sigs:master.

@MartinForReal MartinForReal force-pushed the fixdnslabel branch 2 times, most recently from 94a14cb to ba9b416 Compare October 31, 2022 14:22
@MartinForReal
Copy link
Contributor Author

/retest

@MartinForReal
Copy link
Contributor Author

/cherrypick release-1.25

@k8s-infra-cherrypick-robot
Copy link

@MartinForReal: once the present PR merges, I will cherry-pick it on top of release-1.25 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MartinForReal
Copy link
Contributor Author

/cherrypick release-1.24

@k8s-infra-cherrypick-robot
Copy link

@MartinForReal: once the present PR merges, I will cherry-pick it on top of release-1.24 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MartinForReal
Copy link
Contributor Author

/cherrypick release-1.23

@k8s-infra-cherrypick-robot
Copy link

@MartinForReal: once the present PR merges, I will cherry-pick it on top of release-1.23 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MartinForReal
Copy link
Contributor Author

/cherrypick release-1.1

@k8s-infra-cherrypick-robot
Copy link

@MartinForReal: once the present PR merges, I will cherry-pick it on top of release-1.1 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MartinForReal
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2022
@MartinForReal
Copy link
Contributor Author

/test pull-cloud-provider-azure-unit

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2022
@jwtty
Copy link
Member

jwtty commented Nov 3, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 3, 2022
@MartinForReal
Copy link
Contributor Author

/retest

2 similar comments
@MartinForReal
Copy link
Contributor Author

/retest

@MartinForReal
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit ad90def into kubernetes-sigs:master Nov 3, 2022
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 3, 2022
Closed
@k8s-infra-cherrypick-robot
Copy link

@MartinForReal: new pull request created: #2693

In response to this:

/cherrypick release-1.25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 3, 2022
Closed
@k8s-infra-cherrypick-robot
Copy link

@MartinForReal: new pull request created: #2694

In response to this:

/cherrypick release-1.24

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot
Copy link

@MartinForReal: new pull request created: #2695

In response to this:

/cherrypick release-1.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 3, 2022
Closed
@k8s-infra-cherrypick-robot
Copy link

@MartinForReal: new pull request created: #2696

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 3, 2022
Closed
This was referenced Nov 4, 2022
Merged
Merged
Merged
Merged
@MartinForReal MartinForReal deleted the fixdnslabel branch November 4, 2022 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@lzhecheng lzhecheng Awaiting requested review from lzhecheng

Assignees

@jwtty jwtty

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MartinForReal @k8s-ci-robot @coveralls @k8s-infra-cherrypick-robot @jwtty