Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.24] chore: remove orphaned nic from lb backend pool if the corresponding … #2845

Merged

Conversation

nilo19
Copy link
Contributor

@nilo19 nilo19 commented Dec 2, 2022

…vm is not found

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

There is a chance that the VM is deleted but its nic is still referred by the lb backend pool. This PR removes the orphaned nic references when the VM is not found to reduce API calls.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

chore: remove orphaned nic from lb backend pool if the corresponding VM is not found

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 2, 2022
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2022
@coveralls
Copy link

coveralls commented Dec 2, 2022

Coverage Status

Coverage increased (+0.02%) to 80.056% when pulling b7b1e30 on nilo19:chore/cherry-pick-2834-1.24 into 3b42aee on kubernetes-sigs:release-1.24.

@nilo19 nilo19 force-pushed the chore/cherry-pick-2834-1.24 branch from b4f8332 to b7b1e30 Compare December 2, 2022 08:33
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer, nilo19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 43d1bf2 into kubernetes-sigs:release-1.24 Dec 2, 2022
@nilo19 nilo19 deleted the chore/cherry-pick-2834-1.24 branch December 3, 2022 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants