New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.23] Fix k8s-azure-dns-label-service tag not deleted with Service #2912
Merged
k8s-ci-robot
merged 1 commit into
kubernetes-sigs:release-1.23
from
lzhecheng:cp-2866-23
Dec 14, 2022
Merged
[release-1.23] Fix k8s-azure-dns-label-service tag not deleted with Service #2912
k8s-ci-robot
merged 1 commit into
kubernetes-sigs:release-1.23
from
lzhecheng:cp-2866-23
Dec 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/release-note-label-needed
Indicates that a PR should not merge because it's missing one of the release note labels.
label
Dec 12, 2022
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lzhecheng The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
do-not-merge/needs-kind
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
and removed
do-not-merge/release-note-label-needed
Indicates that a PR should not merge because it's missing one of the release note labels.
labels
Dec 12, 2022
/retest |
Bug: When a Service with DNS label is deleted, k8s-azure-dns-label-service tag won't be deleted and it leads to ensurePublicIPExists error. Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
lzhecheng
force-pushed
the
cp-2866-23
branch
from
December 13, 2022 02:47
a637754
to
1d8443c
Compare
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Dec 13, 2022
/kind bug |
k8s-ci-robot
added
kind/bug
Categorizes issue or PR as related to a bug.
and removed
do-not-merge/needs-kind
labels
Dec 13, 2022
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/bug
Categorizes issue or PR as related to a bug.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix k8s-azure-dns-label-service tag not deleted with ServiceBug: When a Service with DNS label is deleted, k8s-azure-dns-label-service tag won't be deleted and it leads to ensurePublicIPExists error.
Signed-off-by: Zhecheng Li zhechengli@microsoft.com
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix k8s-azure-dns-label-service tag not deleted with Service
Bug: When a Service with DNS label is deleted, k8s-azure-dns-label-service tag won't be deleted and it leads to ensurePublicIPExists error.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: